Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional sort #88

Open
MaksOta opened this issue Dec 4, 2024 · 2 comments
Open

Optional sort #88

MaksOta opened this issue Dec 4, 2024 · 2 comments

Comments

@MaksOta
Copy link

MaksOta commented Dec 4, 2024

Hey,

great tool!

I know sorting was requested and introduced a while back and i would like to express my opinion on why it should be optional

If you are using version tracking for your project and keep track of translation files then if multiple team members add translations, the keys are potentially inserted somewhere in the middle of the list. And after merge and rebase you can get some conflicts that look really scary to resolve. If the translations are in the order of creation then they are always added at the bottom of the file and it looks much nicer when you have to resolve these conflicts.

Thanks

@Albert221
Copy link
Member

Hey!

Are you referring to a situation where these multiple team members would add new translations to POEditor? Because in this case, when you get merge conflicts you can just run the tool with poe2arb poe again and you'll have the most fresh ARB from POEditor, free of conflicts.

If you're referring to editing the ARB files by hand, are you using poe2arb seed for uploading these new translations then? That wasn't originally intended to be the purpose of this command, but I'd be happy to learn how others use this tool, so if do that, please describe your process :)

As for the solution, of course, you could try and ask other devs to also add translations following the alphabetical order to ARBs. But I understand that's not ideal.

@MaksOta
Copy link
Author

MaksOta commented Dec 5, 2024

Are you referring to a situation where these multiple team members would add new translations to POEditor? Because in this case, when you get merge conflicts you can just run the tool with poe2arb poe again and you'll have the most fresh ARB from POEditor, free of conflicts.

This is true yes.

So since i dont have a really good argument anymore how about because i like it more if new terms are added to the end :)

I dont really know how much of your time this takes. Its not a biggie. But if you find the time, maybe consider it?
I would create a PR but i never worked with GO. Maybe its time to start?

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants