Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow on Tiled Roofs #56

Open
Zygus42 opened this issue Sep 25, 2019 · 12 comments
Open

Snow on Tiled Roofs #56

Zygus42 opened this issue Sep 25, 2019 · 12 comments

Comments

@Zygus42
Copy link

Zygus42 commented Sep 25, 2019

minecolonies-1.12.2-0.10.351-ALPHA-universal

Expected behavior

Snow fitting to roof tile shape.

Actual behaviour

2019-09-25_20 18 14

Steps to reproduce the problem

Let it snow.

@Asherslab
Copy link
Member

there's nothing we can generally do about that other than simply disabling snow on our roof tiles

@Raycoms
Copy link
Contributor

Raycoms commented Sep 27, 2019 via email

@Asherslab
Copy link
Member

possibly? however snow is an actual block so we couldn't just adjust that. instead we'd have to have seperate models for our shingles, which would also mean in the very least twice as many models

@Raycoms
Copy link
Contributor

Raycoms commented Sep 27, 2019 via email

@Asherslab
Copy link
Member

an overlay? not sure what you mean there, any rendering is done via models.

@Raycoms
Copy link
Contributor

Raycoms commented Sep 27, 2019 via email

@cltnschlosser
Copy link
Member

cltnschlosser commented Sep 27, 2019 via email

@Asherslab
Copy link
Member

@cltnschlosser would require a different model (as mentioned)
@Raycoms waterlogged is a full block of water "overlayed"
while that would technically work, that's not how snow layers usually look in MC, it would be really weird looking that way, plus it wouldn't be solid, we'd also have to create a crap tonne of code to mimic that vanilla behaviour (waterlogged blocks changed crap tonnes of stuff in mc)

@Raycoms
Copy link
Contributor

Raycoms commented Sep 28, 2019

OKay, then we should probably just disable snow on them

@Zygus42
Copy link
Author

Zygus42 commented Sep 28, 2019

There's several mods that add snow layers to stairs etc, but I tried them all when i was building my latest mod pack, and they use weird workarounds that are not very server friendly.

@Asherslab
Copy link
Member

@Zygus42 yes there are mods that enable that type of thing, however that would require us to also add code to either support those mods, or add those types of features into our own, this isn't something that we'd really want to do, nor would it be very feasible due to the fact that our shingles, while similar to stairs and technically are stairs, have different models/textures/etc from stairs

@Zygus42
Copy link
Author

Zygus42 commented Sep 28, 2019

I wasn't suggesting you do, in fact, I was just pointing out that there doesn't seem an easy solution to this problem in minecraft as it stands. Without, as you say, adding new models for a fairly fringe situation. On the other hand, snow would fit the look of your tile set perfectly, making it look like a european christmas scene.

@Raycoms Raycoms transferred this issue from ldtteam/Structurize May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants