Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello from Waku #6

Closed
dai-shi opened this issue Sep 30, 2023 · 10 comments
Closed

Hello from Waku #6

dai-shi opened this issue Sep 30, 2023 · 10 comments

Comments

@dai-shi
Copy link

dai-shi commented Sep 30, 2023

Just saying hello, but also wondering if there's any possibility for collaboration. https://github.com/dai-shi/waku

@lazarv
Copy link
Owner

lazarv commented Oct 1, 2023

Hi @dai-shi! Welcome here! I'm very glad you're interested!

I did not yet prepared any docs/workflows for collaboration, but yes, absolutely! The first thing I would like to ask from anyone interested is to try out the framework and report any issues. I'm working on the initial documentation right now, so people will not need to get into the source code to find out how is this working.

This is by nature an experimental framework and I just made this public as soon as this was at least usable based on the examples I created and all the main functionality I planned was ready, so this is still rough around the edges. There will be issues I'm sure and I'm fixing things on the go already, but surely I can miss a lot. I will also collect and create tickets for all known issues.

I also don't have any tests for now, but if this project gets more attention then it's a must have to implement.

I'm also open to discuss any part of the framework, there are only a few bits and pieces and the overall vision of this framework I would not like to change. The discussion board is also not setup yet.

Again, thanks for being aware of this project and let me know if you have any suggestions!

@harishnanthan
Copy link

can I join with you?

@dai-shi
Copy link
Author

dai-shi commented Oct 1, 2023

I'm currently working on Waku to bring it to a production level.
By the collaboration, I mean, as both of your project and my projects are based on Vite, we would be solving same problems for each. For example, if we could share some Vite plugins to provide some building blocks, it might be more productive. It might not be that easy with different architecture though.

@lazarv
Copy link
Owner

lazarv commented Oct 1, 2023

Hi @harishnanthan, please see my first comment above. Same goes for anyone interested. Most important thing I need is feedback.

@lazarv
Copy link
Owner

lazarv commented Oct 1, 2023

Happy to hear that you are planning to make Waku into a production ready solution @dai-shi. On that note, what do you think about that React with RSC features is still only available as canary/experimental?

if we could share some Vite plugins to provide some building blocks

Sadly I only use just a few for use client/server; transforms and one for build, but all of these are tailored for this exact framework.

My architecture and approach is very different compared to yours in Waku. I'm all-in on server-side rendering and closer to Next.js. If you can think of anything I could share from this project with you, feel free to just borrow or ask for knowledge I gathered during the development of react-server.

Still I would very appreciate any feedback you could give.

@dai-shi
Copy link
Author

dai-shi commented Oct 1, 2023

https://react.dev/blog/2023/05/03/react-canaries

Unlike the Experimental channel, React Canaries only include features that we reasonably believe to be ready for adoption. We encourage frameworks to consider bundling pinned Canary React releases.

We pin the version but don't bundle it. I think it's rather fair at least for now.

@lazarv
Copy link
Owner

lazarv commented Oct 1, 2023

Yeah, I know about the official standpoint, but I think until React with RSC support is not released as the latest non-canary and non-experimental version, anyone else using it can't really consider it production ready as there are still changes happening affecting these features. That's why I call my framework as an experimental framework.

It's also harder to manage a pinned React version in these frameworks than just using React provided by the developer using these frameworks and even could be misleading as you still install a React and that will be not used at all.

@CharidimosTzedakis
Copy link

Hello there @lazarv ! :)
I also find the project very interesting - would be glad to help out.
As a first step maybe I could try to give some feedback, open some issues , run the examples, see areas for improvement.
Also maybe I could write some tests as well if that comes in handy.

Again congratz for setting it up and for the nice blog posts ! :)

@lazarv
Copy link
Owner

lazarv commented Aug 31, 2024

Hi @CharidimosTzedakis!

First of all, thanks for showing interest in this project! I'm grateful for any help including all you kindly offered.

As a first step maybe I could try to give some feedback, open some issues , run the examples, see areas for improvement.

I'm in progress with building out all of the workflows to help contributors creating issues and pull requests, but I would say to don't hold back and please open issues or start a discussion. You can provide feedback under discussions at https://github.com/lazarv/react-server/discussions/categories/feedback.

Also maybe I could write some tests as well if that comes in handy.

There are some tests in place, but especially if you find an issue, it would be great if you could add a test case to reproduce it and keep it in the test suite for future quality check.

Again congratz for setting it up and for the nice blog posts ! :)

Thanks! I will keep publishing more and hopefully I can still make them better and better with each new blogpost.

@dai-shi
Copy link
Author

dai-shi commented Aug 31, 2024

Let me close this as OP is answered.

@dai-shi dai-shi closed this as completed Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants