feat: return a wrapper on Response on UnexpectedResponse #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n be parsed for errors
spolu
changed the title
spolu
changed the title
enh: expose headers in ResponseWrapper
fix: don't expose hyper HeaderMap
…rror fix: move header error out of enum
SSE::Connected event to return status and headers
|
I am sorry for the delay in responding to this PR. I have some things I need to wrap up early this week, but I will try to take a look before the end of the week. |
|
@spolu thank you for your patience with this. I had originally planned on getting back to this sooner than this, but several things came up and required my attention. Both you and another developer have contributed PRs providing some similar behavior. I have merged your work, along with theirs, into a new PR (#79) and included some adjustments we would also like to make. I'm going to close this PR and keep all communication focused on that new PR. Once again, thank you for your contribution and I look forward to hearing if this new PR works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
To give access to body bytes to let the user parse the response body for API errors when status code is not 200.
Package it as a wrapper to prevent interference across hyper versions