Wrap selection (aka regions)

[daleeidd]

What happens currently:

What should happen is the selection (grey) being wrapped with quotes.

Thank you for the great package!

[laughedelic]

Hi @daleeidd! I'm not using visual vim mode in fish, so I haven't notice it, but you are right, this is a great idea.

Do you have any ideas for the implementation? How do you get the information about selected region?

[daleeidd]

I am using selected regions in default mode. I have it so that the command line behaves like any text editor using familiar macOS bindings. I forgot that working with selected regions (at least in default mode) requires custom logic and state since none of the required input functions (kill-selection and yank) behave as expected when used together with commandline --insert.

Apologies for the inconvenience.

[daleeidd]

I have started working on a library which will make handling selected regions in default mode possible. I'll post it here once I am done, and we will see if it is still a feature suitable to add to this package.

[laughedelic]

@daleeidd nice! It would be really cool if you could implement it 👍