Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font name is nil in log messages #292

Open
Udi-Fogiel opened this issue Nov 8, 2024 · 3 comments
Open

font name is nil in log messages #292

Udi-Fogiel opened this issue Nov 8, 2024 · 3 comments
Labels
fixed in dev already fixed

Comments

@Udi-Fogiel
Copy link

There are several log messages that use a nil variable (fontname):

logreport ("log", 1, "aux",
"font no %d (%s) defines feature %s "
.. "for script %s with language %s",
font_id, fontname, asked_feature,
asked_script, asked_language)

logreport ("log", 0, "aux",
"font no %d (%s) does not define feature %s for script %s with language %s",
font_id, fontname, asked_feature, asked_script, asked_language)

logreport ("log", 0, "aux",
"font no %d (%s) defines no feature "
.. "for script %s with language %s",
font_id, fontname, asked_script, asked_language)

logreport ("log", 1, "aux",
"font no %d (%s) defines feature %s "
.. "for script %s with language %s",
font_id, fontname, feature,
asked_script, asked_language)

In adiition, can these (and the other aux related) messages be optional and only be displayed if asked (with some kind of a debugging option)?

@Udi-Fogiel
Copy link
Author

Also note that with harfbuzz these messages are not displayed. Compare

\input luaotfload.sty
\font\foo={name:TeX Gyre Termes:mode=harf}\foo
\directlua{
bool = luaotfload.aux.provides_language(font.current(),'latn','eng')
}
\end

with

\input luaotfload.sty
\font\foo={name:TeX Gyre Terme}\foo
\directlua{
bool = luaotfload.aux.provides_language(font.current(),'latn','eng')
}
\end

@zauguin
Copy link
Member

zauguin commented Nov 17, 2024

Replaced the nil with an actual fontname and increase their log level to 2 since they are at most tracing output.

@zauguin zauguin added the fixed in dev already fixed label Nov 17, 2024
@Udi-Fogiel
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in dev already fixed
Projects
None yet
Development

No branches or pull requests

2 participants