Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--database=sqlite with --jet causes Jetstream migration run to fail (database.sqlite is not created) #345

Closed
nikspyratos opened this issue Jun 13, 2024 · 0 comments · Fixed by #346
Labels

Comments

@nikspyratos
Copy link

Installer Version

5.8.2

Description

Heyo.

Preface: Not a major issue really, can be resolved after the fact and does not affect the rest of the installer.

Been experimenting with the installer to refactor some of my project to use it, and came across this quirk.

If one runs laravel new myproject, it will ask you which database to use, and run migrations, and warn you there is no database file and ask to create it.

However if you run laravel new myproject --database=sqlite --jet, it does not ask you if you'd like to run these migrations the first time, and so the second time when jetstream installs and asks to run migrate:fresh --force, it tries to run them without prompting to first create the database file, which errors for the migrations.

I've been reading through the installer, migrate and Jetstream installer source and I'm still not 100% certain why this happens, otherwise I'd have PR'd this to the appropriate repo.

Steps To Reproduce

  • Run laravel new --jet, get prompted for DB, get prompted to create DB, get prompted to rerun migrations on jetstream install, no issues, rest of installer proceeds as normal
  • Run laravel new --database=sqlite --jet, don't get prompted for DB, don't get prompted to create db, get prompted to rerun migrations on jetstream install, migrations fail, rest of installer proceeds as normal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants