diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 34f86d0..afb33ac 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -16,8 +16,11 @@ jobs: strategy: fail-fast: true matrix: - php: [8.2, 8.3] + php: [8.2, 8.3, 8.4] laravel: [10, 11] + exclude: + - php: 8.4 + laravel: 10 name: PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }} @@ -35,11 +38,10 @@ jobs: - name: Install dependencies run: | - composer require "laravel/framework=^${{ matrix.laravel }}" --no-update - composer update --prefer-dist --no-interaction --no-progress + composer update --prefer-dist --no-interaction --no-progress --with="illuminate/support=^${{ matrix.laravel }}" - name: Execute tests - run: vendor/bin/phpunit + run: vendor/bin/phpunit --display-deprecations --fail-on-deprecation windows_tests: runs-on: windows-latest @@ -47,8 +49,11 @@ jobs: strategy: fail-fast: true matrix: - php: [8.2, 8.3] + php: [8.2, 8.3, 8.4] laravel: [10, 11] + exclude: + - php: 8.4 + laravel: 10 name: PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }} - Windows @@ -72,8 +77,7 @@ jobs: - name: Install dependencies run: | - composer require "laravel/framework=~${{ matrix.laravel }}" --no-update - composer update --prefer-dist --no-interaction --no-progress + composer update --prefer-dist --no-interaction --no-progress --with="illuminate/support=~${{ matrix.laravel }}" - name: Execute tests - run: vendor/bin/phpunit + run: vendor/bin/phpunit --display-deprecations --fail-on-deprecation diff --git a/src/NewCommand.php b/src/NewCommand.php index e6d1dbc..df7ebbe 100644 --- a/src/NewCommand.php +++ b/src/NewCommand.php @@ -904,7 +904,7 @@ protected function runOnValetOrHerd(string $command) * @param array $env * @return \Symfony\Component\Process\Process */ - protected function runCommands($commands, InputInterface $input, OutputInterface $output, string $workingPath = null, array $env = []) + protected function runCommands($commands, InputInterface $input, OutputInterface $output, ?string $workingPath = null, array $env = []) { if (! $output->isDecorated()) { $commands = array_map(function ($value) {