Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplying factor of h/(2*\pi) missing? #51

Closed
sambuddhac opened this issue Nov 17, 2024 · 4 comments
Closed

Multiplying factor of h/(2*\pi) missing? #51

sambuddhac opened this issue Nov 17, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sambuddhac
Copy link

Shouldn't the first equation in the What is Quantum Annealing? of the doc pages have a multiplying factor of h/(2*\pi) on the left-hand-side of the equation?

@zmorrell
Copy link
Collaborator

I just checked the way we have it worded and we were hoping that the expression "acting over a set of $n$ qubits in natural units" would be sufficient to indicate that we intended for $\hbar = 1$. Upon re-reading it and seeing that an issue has been created about it, I will update the documentation to explicitly state this. Thank you for pointing out where the documentation was unclear. Please let us know if you come across anything else that seems off or is poorly worded.

@zmorrell
Copy link
Collaborator

I have added a proposed change to index.md in the "doc-clarity" branch (8bc681e). If you are in agreement that this clarifies things successfully, I will merge into the main documentation

@zmorrell zmorrell added the documentation Improvements or additions to documentation label Nov 17, 2024
@zmorrell zmorrell self-assigned this Nov 17, 2024
@sambuddhac
Copy link
Author

sambuddhac commented Nov 17, 2024

I have added a proposed change to index.md in the "doc-clarity" branch (8bc681e). If you are in agreement that this clarifies things successfully, I will merge into the main documentation

@zmorrell Thank you for taking care of it, immediately. I just saw the PR and I approve it. I think, it's good practice to keep things explicit on the doc pages (and elsewhere) more so, for a topic like this, where there are users and developers like me, who are not always from a traditional physics background, so that, they may not face any confusion. I will probably contribute more in the coming days to the repo in the form of PRs and issues, since I just started working with some Quantum Computing stuff. Thank you once again.

Cheers !!!

@zmorrell
Copy link
Collaborator

I am going to close this issue in favor of additional issues/pull requests being created in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants