Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with bootstrapping #1

Open
tylercollier opened this issue Dec 10, 2015 · 3 comments
Open

Issue with bootstrapping #1

tylercollier opened this issue Dec 10, 2015 · 3 comments

Comments

@tylercollier
Copy link

#1. Output path

I'm thinking the example config file is misleading. It says to put it in config/webpack.js, but then shows this:

module.exports.webpack = {
  options: {
    ...
    output: {
      path: path.resolve(__dirname, '.tmp/public/js'),
...

Won't that make the output path config/.tmp/public/js? It does for me. To fix, I changed the second argument to path.resolve to be ../.tmp/public/js.
#2. Loading webpacked assets

There's no mention of it, but shouldn't we put something like the following in the layout.ejs?

<script src="/js/bundle.js"></script>
@tylercollier
Copy link
Author

Also, you should put

var path = require('path');

at the top of config/webpack.js.

BaggersIO added a commit to BaggersIO/sails-webpack that referenced this issue Jan 4, 2016
Updated docs for an easier implementation.
@BaggersIO
Copy link

+1

@tylercollier Yep, I ran into the same issue. Just created a PR.

@tylercollier
Copy link
Author

Looks great, thanks!

On Mon, Jan 4, 2016 at 2:04 PM, Peter Müller [email protected]
wrote:

+1

@tylercollier https://github.com/tylercollier Yep, I ran into the same
issue. Just created a PR.


Reply to this email directly or view it on GitHub
#1 (comment)
.

tjwebb added a commit that referenced this issue Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants