Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for GHC 8.2 #26

Open
abhin4v opened this issue Feb 3, 2018 · 4 comments
Open

Update for GHC 8.2 #26

abhin4v opened this issue Feb 3, 2018 · 4 comments

Comments

@abhin4v
Copy link

abhin4v commented Feb 3, 2018

The library currently does not work on GHC 8.2 which has been out for couple of months now. Please update the dependencies and the code to make it work on GHC 8.2.

@LouisLotter
Copy link

Hi. is any updates planned for this library ? If not can anyone suggest any alternatives ?

@jfla
Copy link

jfla commented Dec 9, 2022

I have the same question in 2022. It appears that the FastInteger type is closely coupled with GHC internals so would be difficult to migrate. However, I got the library to build on GHC 9.2.5 by cutting out all that stuff and BitSet.Dynamic. This leaves us with the generic BitSet which can still be used with Integer in a dynamic way. It could even be that Integer has been updated in recent years to support fast bitflipping, then we won't have any performance loss.

I suggest abandoning BitSet.Dynamic in favour of a simple BitSet Integer - this will be a quick way to resurrect this package and provide the same functionality/performance it had before v1.3.0. If anyone wants to rewrite the GHC.Integer stuff they can do that later.

I could look at providing an initial patchset - just hoping that the maintainer still checks this issue list

@superbobry
Copy link
Member

Thanks @jfla, the plan sounds good to me. Feel free to go ahead with a PR.

As for Integer in GHC, the patches I've sent 9 years ago were never accepted, so it is hard to say what the current state of bitflipping is.

@jfla
Copy link

jfla commented Dec 11, 2022

Great. I will put a PR together. I see that someone ported FastInteger to GHC 8.10 (#27). I'll try to incorporate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants