You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've tried to skip logs for 404 and 429 but was unable to by using a simple Skipper because it is evaluated before next has been called and therefore the status is always 200.
Checklist
Dependencies installed
No typos
Searched existing issues and docs
Expected behaviour
Being able to skip based on the status
Actual behaviour
Skipper is called before the status has been set
Steps to reproduce
Trigger a 404
See the log being outputted
Add a print in the middleware, see status 200 on 404 requests
Naively I thought that the skipper (in the log context) scope was to skip logs for any situation and the request logger reserved to 3rd party integrations and/or customization.
I think we can close this issue then, I'll go with your suggested solution, thanks!
Issue Description
I've tried to skip logs for 404 and 429 but was unable to by using a simple Skipper because it is evaluated before
next
has been called and therefore the status is always 200.Checklist
Expected behaviour
Being able to skip based on the status
Actual behaviour
Skipper is called before the status has been set
Steps to reproduce
Working code to debug
See https://github.com/shortcuts/codes/pull/9/files also if you want to see the full file
Version/commit
Latest
The text was updated successfully, but these errors were encountered: