hotfix: sudo_session_enable setting doesn't work
#2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.2% | 398/7652 |
| 🔴 | Branches | 4.45% | 237/5323 |
| 🔴 | Functions | 3.1% | 78/2519 |
| 🔴 | Lines | 5.12% | 383/7483 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 4405000
agatha197
added
urgency:blocker
Graphite App
github-actions
bot
added
field:UI / UX
type:fix
agatha197
removed
the
urgency:4
Merge activity
|
closes #2964 Updates the user settings modification logic to use `_.isNil` instead of `_.isEmpty` when filtering properties, ensuring that `sudo_session_enable` is changed properly. **Checklist:** - [x] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
hotfix/sudo-session-enabled-does-not-work
branch
from
4405000 to
f110ee5
Compare
graphite-app
bot
deleted the
hotfix/sudo-session-enabled-does-not-work
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2964
Updates the user settings modification logic to use
_.isNilinstead of_.isEmptywhen filtering properties, ensuring thatsudo_session_enableis changed properly.Checklist: