Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open type chart editor (SWSH) #339

Open
zhengtaohong opened this issue Sep 11, 2023 · 9 comments
Open

Can't open type chart editor (SWSH) #339

zhengtaohong opened this issue Sep 11, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@zhengtaohong
Copy link

Hello, may I ask how to modify the effects of items, such as the multiplier of the Life Orb or whether the item is consumed after use? These features are available in PK3DS, but does PKNX currently lack them? Can they be updated? Thank you very much!

@kwsch
Copy link
Owner

kwsch commented Sep 11, 2023

These features are available in PK3DS

No they aren't; the game code's damage formula is what handles the item's in-game effects, which is not editable, and no plans to.

@kwsch kwsch closed this as not planned Won't fix, can't repro, duplicate, stale Sep 11, 2023
@zhengtaohong
Copy link
Author

may I ask if it is possible to modify the effectiveness between types, such as making Bug type restrain Fairy type?

@kwsch
Copy link
Owner

kwsch commented Sep 11, 2023

The type chart editor already handles this for SW/SH and LGP/E.
https://github.com/kwsch/pkNX/blob/master/pkNX.WinForms/Subforms/TypeChart.cs

@zhengtaohong
Copy link
Author

I have downloaded the latest version of PKNX, but there is no type chart option after opening Sword. Do I need to do anything else?

@duckdoom4
Copy link
Collaborator

https://github.com/kwsch/pkNX/blob/master/pkNX.WinForms/MainEditor/EditorSWSH.cs#L184

It appears that editor is marked as 'not working'

@zhengtaohong
Copy link
Author

@duckdoom4 Sorry, I didn't quite understand what you meant. What should I do to open the type chart editor in PKNX?
图片

@duckdoom4
Copy link
Collaborator

You can't, the editor is not working. To get it working you'd have to fix the code :p

@zhengtaohong
Copy link
Author

@duckdoom4 okay,thank you

@duckdoom4 duckdoom4 changed the title Can Item editor be updated? Can't open type chart editor (SWSH) Sep 12, 2023
@duckdoom4
Copy link
Collaborator

duckdoom4 commented Sep 12, 2023

I'll reopen this and change the title to have a reminder that someone should fix it at some point. Can't say who or when

@duckdoom4 duckdoom4 reopened this Sep 12, 2023
@duckdoom4 duckdoom4 added the bug Something isn't working label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants