Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Underwater Diving #81

Open
mertymcgraw opened this issue Dec 10, 2024 · 4 comments
Open

Add Support for Underwater Diving #81

mertymcgraw opened this issue Dec 10, 2024 · 4 comments

Comments

@mertymcgraw
Copy link

mertymcgraw commented Dec 10, 2024

Is your feature request related to a problem? Please describe.
With the launch of the Apple Watch Ultra, underwaterDiving was added as a HKWorkoutActivityType. Currently, workout queries that have underwater diving activities in the returned List<Workout> throw the Unknown value: 84 error.

Describe the solution you'd like
Please add underwaterDiving as a WorkoutActivityType. I am happy to put up a PR.

@kvs-coder
Copy link
Owner

hi @mertymcgraw

please check the latest release https://pub.dev/packages/health_kit_reporter/changelog#211---29052023 and sorry for my long absence

@mertymcgraw
Copy link
Author

@kvs-coder I am still not seeing underwaterDiving as workout activity type in here. Would it be possible to add? Happy to put up the pr if needed.

@kvs-coder
Copy link
Owner

kvs-coder commented Dec 12, 2024

hey @mertymcgraw

I please check now, I added missing types to the workoutType including underwaterDiving https://github.com/kvs-coder/health_kit_reporter/blob/master/lib/model/payload/workout_activity_type.dart#L266

New version of the package 2.3.1 https://pub.dev/packages/health_kit_reporter

@mertymcgraw
Copy link
Author

Thank you so much @kvs-coder!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants