-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle paginated results in e2e-upgrade-functests #794
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
/remove-lifecycle rotten |
Is this a BUG REPORT or FEATURE REQUEST?:
What happened:
https://github.com/kubevirt/ssp-operator/blob/54285313efecb017c47744dda5b666bdfd4a1c56/automation/e2e-upgrade-functests/run.sh#L24C20-L24C86
This scripts queries for release branches and by default there is a limit of 30 items per page.
Since dependabot started creating a lot of branches, the branches we are looking for are no longer returned on page one. This resulted in the CI failing.
See #792
What you expected to happen:
The script should handle paginated results, see https://docs.github.com/en/rest/branches/branches?apiVersion=2022-11-28#list-branches--parameters
How to reproduce it:
Anything else we need to know?:
Environment:
virtctl version
):kubectl version
):uname -a
):The text was updated successfully, but these errors were encountered: