Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow, rehearse: improvements to comment #3840

Open
dhiller opened this issue Dec 18, 2024 · 1 comment
Open

prow, rehearse: improvements to comment #3840

dhiller opened this issue Dec 18, 2024 · 1 comment
Labels
area/prow Issues and PRs concerning KubeVirt Prow, i.e. configuration, setup etc. good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors.

Comments

@dhiller
Copy link
Contributor

dhiller commented Dec 18, 2024

Problem

The comment currently is not entirely correct. It neglects the recent changes due to the group of people being allowed to rehearse. Also the comment around how to use the plugin should be hidden in a details section, in order to reduce the visible size of the comment.

Proposed solution

Change text2 as described below.

Proposal for text:

<details>

A rehearsal can be triggered for all jobs by commenting either `/rehearse` or `/rehearse all` on this PR.

A rehearsal for a specific PR can be triggered by commenting `/rehearse {job-name}`.

Commenting `/rehearse ?` triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the `ok-to-rehearse` label.

Authorized users are the group of users that are members of the KubeVirt GitHub 
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the `project-infra` project.

[1]: see [OWNERS](https://www.kubernetes.dev/docs/guide/owners/#owners) file definition for reference.

</details>

Example:

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific PR can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

/good-first-issue
/area prow

@kubevirt-bot
Copy link
Contributor

@dhiller:
This request has been marked as suitable for new contributors.

Guidelines

  • No Barrier to Entry
  • Clear Task
  • Solution Explained
  • Provides Context
  • Identifies Relevant Code
  • Gives Examples
  • Ready to Test
  • Goldilocks priority
  • Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Problem

The comment currently is not entirely correct. It neglects the recent changes due to the group of people being allowed to rehearse. Also the comment around how to use the plugin should be hidden in a details section, in order to reduce the visible size of the comment.

Proposed solution

Change text2 as described below.

Proposal for text:

<details>

A rehearsal can be triggered for all jobs by commenting either `/rehearse` or `/rehearse all` on this PR.

A rehearsal for a specific PR can be triggered by commenting `/rehearse {job-name}`.

Commenting `/rehearse ?` triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the `ok-to-rehearse` label.

Authorized users are the group of users that are members of the KubeVirt GitHub 
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the `project-infra` project.

[1]: see [OWNERS](https://www.kubernetes.dev/docs/guide/owners/#owners) file definition for reference.

</details>

Example:

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific PR can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

/good-first-issue
/area prow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added area/prow Issues and PRs concerning KubeVirt Prow, i.e. configuration, setup etc. good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues and PRs concerning KubeVirt Prow, i.e. configuration, setup etc. good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors.
Projects
None yet
Development

No branches or pull requests

2 participants