-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake-stats: add number of merged PRs per day to box #3630
Comments
/good-first-issue |
@dhiller: Guidelines
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dhiller I'll take a look. Thank you !! |
@dhiller Do we need the extra row
Under |
Yes, I think that's good enough for now - the goal is to make readers understand that the sheer amout of errors might be in correlation to the number of PRs that have been merged on that day. Also there's no such number to show for the periodic jobs, which might confuse the reader. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Is your feature request related to a problem? Please describe:
The flake-stats report1 is our main tool to look at flaky tests during the SIG-CI meetings currently. It's been proven extremely useful to get a quick overview about where things go wrong. This is achieved by the overviews that aggregate failures per day and per lane.
Now, sometimes it seems that there are a lot of failures that have occurred on one day, solely being caused by the fact that a lot of PRs have been merged on that day - reason of this is that the sum of failures per day is taken from the flakefinder report which aggregates all the failures of a merged PR towards the day it was merged, and not towards the day the failure itself occurred.
Note
Example: a PR that was created on Dec 21st and is merged on Jan 1st, during that period it's test lanes had been run several times, and there were some unit test failures on those runs. Now, all the failures are accounted towards the day the PR is getting merged, so that exactly that day looks as if a lot of failures occurred at that day - which again is not the case.
Describe the solution you'd like:
By adding the number of merged PRs to a day's numbers we can better spot anomalies - i.e. a high number of test failures even though the number of merged PRs is low might indicate that a flaky or unstable test got introduced.
Thus we want to show the number of PRs that have been merged on the day - added to the box that shows the failures for that day. Sketch:
Additional context:
project-infra/robots/cmd/flake-stats/flake-stats.gohtml
Line 32 in a609d2f
The text was updated successfully, but these errors were encountered: