-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
branch-protection: remove required_status_check for dco on kubevirt/kubevirt.core #2927
Comments
FYI @0xFelix |
IMO 1. might be an option, but 2. sounds like unnecessary duplication and bloat of the manifest. The kubevirt.core repository in general is an exemption, as it is using a lot of GitHub Actions instead of prow. So right now I would also be fine with removing the status check temporarily before a release, as we do not release that often and it's a process that needs to be started manually anyways. |
I agree that this is an exceptional case. Considering the maintainer state in test-infra I am not sure whether we would get a change for branch protector in anyway. However, I am discontent with the situation since we need to remember what to do before a release of kubevirt.core ... Since new repositories are urged to copy branch protection rules anyway, I'd be ok with the redundancy. Anyhow I created this issue just as a reminder for us in case our older selves are wondering about it. Let's just keep it at that for now. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
/lifecycle frozen |
Since kubevirt/kubevirt.core is having problems when doing their release with the dco check making the release fail, we tried to fix it with #2921
Contrary to our expectations branch-protector restores the dco check on the main branch.
We have two options:
The text was updated successfully, but these errors were encountered: