Fix uploading for block devices that exceed requested size #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: no
kvaps
force-pushed
the
fix-check-size-for-block-devices
branch
2 times, most recently
from
c90ef04
to
47c361e
Compare
kubevirt-bot
added
dco-signoff: yes
kvaps
force-pushed
the
fix-check-size-for-block-devices
branch
from
47c361e
to
9c19512
Compare
kvaps
changed the title
kvaps
force-pushed
the
fix-check-size-for-block-devices
branch
from
9c19512
to
15d8a4e
Compare
kvaps
changed the title
|
/assign @awels |
This was referenced Oct 14, 2024
kvaps
force-pushed
the
fix-check-size-for-block-devices
branch
2 times, most recently
from
e633d9f
to
90fdd7f
Compare
Signed-off-by: Andrei Kvapil <[email protected]>
kvaps
force-pushed
the
fix-check-size-for-block-devices
branch
from
90fdd7f
to
38e6d3c
Compare
|
/test pull-cdi-unit-test |
kvaps
added a commit
to aenix-io/cozystack
that referenced
this pull request
Oct 16, 2024
Upstream fix: kubevirt/containerized-data-importer#3461 Signed-off-by: Andrei Kvapil <[email protected]> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new version (`v1beta1`) for the CDI operator alongside the existing version, enhancing configuration options. - Expanded `spec` section with detailed descriptions for various configurations including data volume management and TLS security profiles. - Added a new Ingress resource for the `cdi-uploadproxy` service, improving traffic routing capabilities. - Introduced new configuration parameters for dynamic upload proxy URL management. - **Improvements** - Updated permissions for the CDI operator to manage additional resources, improving its data handling capabilities. - Refined deployment configuration with updated container image references and environment variables for better operational control. - Enhanced network policy definitions by adding specific rules for new services while maintaining existing policies. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Andrei Kvapil <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
universal-itengineer
pushed a commit
to deckhouse/3p-containerized-data-importer
that referenced
this pull request
Oct 29, 2024
…3461) Signed-off-by: Andrei Kvapil <[email protected]>
universal-itengineer
pushed a commit
to deckhouse/3p-containerized-data-importer
that referenced
this pull request
Oct 29, 2024
…3461) Signed-off-by: Andrei Kvapil <[email protected]>
|
/cherrypick release-v1.60 |
|
@akalenyu: new pull request created: #3487 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Various storage providers may provision block devices larger than the size requested by the user. This is often due to LVM or ZFS rounding up to the nearest extent size. (see LINBIT/linstor-server#421 (comment) and #3159 (comment))
Currently, CDI checks the requested size in the PVC and fails the upload if the original block device is larger than the requested size.
This PR changes logic to take requestImageSize into account only for filesystem volumes
Which issue(s) this PR fixes:
Another try to fix #3159
Special notes for your reviewer:
Release note: