Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stale glossary entry for "minikube" #49171

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update stale glossary entry for "minikube" #49171

wants to merge 2 commits into from

Conversation

yuto-kimura-g
Copy link
Contributor

Description

Changes:

  • Specify that minikube supports multi-node

    • Why: To avoid misunderstanding that only single-node is supported.

  • Update internal links

    • Why: The linked page was redirected, and the minikube part was not displayed on the first screen (the area visible without scrolling).

Issue

Closes: #49116

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 19, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 87bc53b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/676459a437799b000889a7cb
😎 Deploy Preview https://deploy-preview-49171--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Dec 19, 2024

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Princesso Princesso Awaiting requested review from Princesso

@salaxander salaxander Awaiting requested review from salaxander

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stale glossary entry for “minikube“
3 participants
@yuto-kimura-g @k8s-ci-robot @sftim