Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub AppID and key authentication to commenter bot #32805

Open
tnozicka opened this issue Jun 21, 2024 · 1 comment · May be fixed by #32806
Open

Add GitHub AppID and key authentication to commenter bot #32805

tnozicka opened this issue Jun 21, 2024 · 1 comment · May be fixed by #32806
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@tnozicka
Copy link
Contributor

What would you like to be added:
I'd like to extend the commenter robot flags, so it can be used with GitHub AppID credentials.

(I understand that GitHub apps can authenticate only for a single installation ID, so the queries will be limited to single org, if such authentication option is used.)

Why is this needed:
The commenter robot accepts only GH token for authentication. This is problematic because it needs a real GH user which will incur additional cost for organizations. More importantly, I have tried creating such account and generating long-lived access token for it in "Developer options" but even with --ceiling=10 and the job run every hour, it got flagged by GitHub after the first run(s) which made its comments invisible to anyone else. My hope it using the GitHub App avoids these bans and is similar to native GitHub workflows that get the automatic token.

/assign

@tnozicka tnozicka added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 21, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 21, 2024
@tnozicka
Copy link
Contributor Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants