-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Notes Collection Picks Up Incorrect Text #3516
Comments
@npolshakova thank you for the bug report, are you considering to work on a fix? |
I'd be interested, but I'm not super familiar with the code that does the release notes collection. Do you think this is an issue on the krel side here? |
@npolshakova I assume it's part of the release notes gathering logic of this repository. We just need a reproducer to see what we can fix. |
I think the issue is in the regex in the exclude filter: https://github.com/kubernetes/release/pull/3523/files I'm able to reproduce it, but still need a fix for the regex. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@npolshakova are you still working on this? /remove-lifecycle stale |
Yep, my team is looking into this still. It looks like the last release notes PR didn't run into this issue though! |
What happened:
Release notes collection automation has resulted in incorrect text and markdown being collected: kubernetes/sig-release#2449 (comment)
You can see examples of this merged in sig-release for 1.30 due to past release notes collection:
Updated examples from 1.29 that are still in the repo after 1.30 was cleaned up:
What you expected to happen:
This release note should not be collected since it is empty:
The text was updated successfully, but these errors were encountered: