Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster_autoscaler_failed_scale_ups_total metric is missing from metrics until an event is registered #7448

Open
elmiko opened this issue Oct 30, 2024 · 5 comments · May be fixed by #7449
Open
Assignees
Labels
area/cluster-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.

Comments

@elmiko
Copy link
Contributor

elmiko commented Oct 30, 2024

Which component are you using?:

cluster-autoscaler

What version of the component are you using?:

Component version: 1.29

What k8s version are you using (kubectl version)?:

1.29

What environment is this in?:

n/a

What did you expect to happen?:

metric should be initialized so that the zero value can be seen in prometheus data.

What happened instead?:

metric does not appear until it has been updated.

How to reproduce it (as minimally and precisely as possible):

  1. start the CA
  2. curl the metrics endpoint and grep for cluster_autoscaler_failed_scale_ups_total

Anything else we need to know?:

this should be fairly straightforward to fix.

@elmiko elmiko added the kind/bug Categorizes issue or PR as related to a bug. label Oct 30, 2024
@elmiko
Copy link
Contributor Author

elmiko commented Oct 30, 2024

/area cluster-autoscaler

@elmiko
Copy link
Contributor Author

elmiko commented Oct 30, 2024

/help-wanted
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@elmiko:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help-wanted
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 30, 2024
@thiha-min-thant
Copy link

Hi @elmiko , could you please assign to me? Thanks!

@JoelSpeed
Copy link
Contributor

/assign @thiha-min-thant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
4 participants