Inconsistent behaviour within VPA components regarding targetRef #6924
Assignees
Labels
Comments
adrianmoisey
added a commit
to adrianmoisey/autoscaler
that referenced
this issue
Jun 16, 2024
Relates to kubernetes#6924 Previously the case of the `Kind` in the `targetRef` didn't matter. Not it seems to matter for the admission-controller. This change attempts to copy what the HPA does. https://github.com/kubernetes/kubernetes/blob/v1.30.0/pkg/controller/podautoscaler/horizontal.go#L1321-L1325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which component are you using?:
vertical-pod-autoscaler
What version of the component are you using?:
Component version: 1.1.2
What k8s version are you using (
kubectl version)?:Various: 1.28 and 1.30
What environment is this in?:
Any. I've reproduced in GKE, AWS (kOps) and Kind.
What did you expect to happen?:
When setting a targetRef with a lowecase
kind, the VPA admission-controller doesn't match the new Pods.However, the updater component does match the Pod.
What happened instead?:
Pod wasn't matched in the admission-controller
How to reproduce it (as minimally and precisely as possible):
Use the hamster example in this repo, and replace "Deployment" with "deployment"
Anything else we need to know?:
deployment/area vertical-pod-autoscaler
/assign
The text was updated successfully, but these errors were encountered: