vpa: Follow golang guidelines for error strings

[ialidzhikov]

Which component are you using?:

vertical-pod-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
Let's take a look into

autoscaler/vertical-pod-autoscaler/pkg/updater/eviction/pods_eviction_restriction.go

Line 390 in e3c8f4c

return nil, fmt.Errorf("Failed to sync %v cache.", kind)

:

• From Go Wiki: Go Code Review Comments: "Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context."

Let's take a look into

autoscaler/vertical-pod-autoscaler/pkg/utils/limitrange/limit_range_calculator.go

Line 84 in e56c2d8

return nil, fmt.Errorf("error loading limit ranges: %s", err)

:

• Errors should be wrapped with %w, not with %s. See https://go.dev/blog/go1.13-errors

Describe the solution you'd like.:

See above.

Describe any alternative solutions you've considered.:

N/A

Additional context.:

N/A

[nikzayn]

@ialidzhikov Can I take this up?

[Shubham82]

@ialidzhikov, I think the same thing (Error string capitalization) is used in many places in the files, so we must update the file to follow the go language approach.

[Shubham82]

@ialidzhikov Can I take this up?

@nikzayn you can work on this issue by assigning it to yourself.

[Shubham82]

cc @voelzmo @kwiesmueller

/area vertical-pod-autoscaler

[nikzayn]

/assign