-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ServicePrincipalCertificate not reading from Secret #5277
Conversation
/assign @willie-yao |
/milestone v1.18 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5277 +/- ##
=======================================
Coverage 52.86% 52.86%
=======================================
Files 270 270
Lines 29121 29123 +2
=======================================
+ Hits 15395 15397 +2
Misses 12933 12933
Partials 793 793 ☔ View full report in Codecov by Sentry. |
/lgtm |
@bryan-cox: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 6ef38c61231a95bc39aaa413e4bae9751750dbd8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This change broke CAPZ's ability to read Service Principal certificate content from a Secret: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/5200/files#diff-b6ab207506064afcbd1d777c1c7296e2953d2653a8843bfb39107af5cf5b0a87R213
I caught this while iterating on some of the unit tests that intersect with this. I'll try to refactor the tests to better catch things like this later.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: