-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node.yaml parse error #1842
Comments
Hi @bryanfang, This looks like a terraform config issue. As the source of the Additionally, I have tried running through the AWS EKS Blueprints for Terraform: Stateful pattern and was able to deploy the EBS CSI Driver via terraform using it. I would suggest looking at that setup for more guidance, or filing an issue on that repository. Those maintainers are the subject matter experts on deploying EKS add-ons via terraform. |
Hi @bryanfang, |
Having same issue , no Terraform here. EDIT: Went back and tried to find when it broke --
|
I am not deep enough here, but this smells weird:
But its Value is commented out? aws-ebs-csi-driver/charts/aws-ebs-csi-driver/values.yaml Lines 413 to 423 in 33fffa3
|
Hi @barbaluc , I did not try to resolve the code issue with this repo, and have to modify volume size manually by following below steps:
hope this helps! |
Hi @bryanfang , @gxpd-jjh, |
Maybe I need to upgrade my argo instance; i'll give it a shot over next day or four. |
Went back to using 2.22.1 helm chart waiting for a new fixed HELM chart or explanation of how to use the values to fix this problem. Thanks @gxpd-jjh |
@bryanfang I think we don't talk about same components. I had the same issue like you when I've upgraded the csi driver chart version. And I've fixed it when I've upgraded the helm terraform provider version. |
I don't use terraform, I am using helm. I install the chart manually. Could it be my helm version. The helm is not intended to be installed as a standalone chart ? |
After you change the volume size in chart, and once after deploy it, did you check if the volume size gets changed? |
I think we are talking about the same issue, node parser issue with version v2.25.0 |
Upgrading my argo from an old version to latest did the trick. Something must have changed in underlying components. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/close Appears to be an issue in third party components (argocd and/or terraform). Please reopen this issue or create a new issue if further support is needed. |
@ConnorJC3: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind bug
What happened?
I need change ALLOWVOLUMEEXPANSION to true to enable resizing volume, looks like need upgrade csi-driver to v1.25
when I try to upgrade csi-driver from v2.20.0 to v2.25.0 by changing the version via terraform code
resource "helm_release" "aws_ebs_csi_driver" {
name = "aws-ebs-csi-driver"
namespace = "kube-system"
repository = "https://kubernetes-sigs.github.io/aws-ebs-csi-driver/"
chart = "aws-ebs-csi-driver"
version = "2.25.0"
values = [data.template_file.values.rendered]
}
but got error message:
18:20:06 Error: parse error at (aws-ebs-csi-driver/templates/node.yaml:1): unclosed action
18:20:06
18:20:06 on main.tf line 20, in resource "helm_release" "aws_ebs_csi_driver":
18:20:06 20: resource "helm_release" "aws_ebs_csi_driver" {
What you expected to happen?
the aws-ebs-csi-driver should be upgraded ti v2.25.0 without error
How to reproduce it (as minimally and precisely as possible)?
put the helm release to terraform code and run it in aws eks
Anything else we need to know?:
how to solve the issue
Environment
AWS EKS
kubectl version
):WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short. Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.0", GitCommit:"1b4df30b3cdfeaba6024e81e559a6cd09a089d65", GitTreeState:"clean", BuildDate:"2023-04-11T17:10:18Z", GoVersion:"go1.20.3", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"28+", GitVersion:"v1.28.3-eks-4f4795d", GitCommit:"e77944ea667aee90c84c48a74a2a0da7a23e0508", GitTreeState:"clean", BuildDate:"2023-10-20T23:21:39Z", GoVersion:"go1.20.10", Compiler:"gc", Platform:"linux/amd64"}
The text was updated successfully, but these errors were encountered: