Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing test that filesystem snapshot cannot be created from block volume, and vice versa #541

Open
ebblake opened this issue Jun 22, 2024 · 0 comments

Comments

@ebblake
Copy link

ebblake commented Jun 22, 2024

Right now, the csi-sanity tests are hardcoded to either always request filesystem (mount) volumes, or to always request block volumes, based on --csi.testvolumeaccesstype XXX (at the csi-sanity CLI).

It might be nice if the CSI spec added a controller capability to advertise whether the controller can create block, filesystem, or both types of volumes, and if csi-sanity then probed that controller capability and auto-determined testvolumeaccesstype accordingly rather than defaulting to filesystem and having to manually be set to block for a block-only driver. (I'll probably create a bug request against CSI proper for that)

But more to the point of this particular request, we noticed while implementing a CSI driver that was originally block only, but where we are now adding filesystem support, that the csi-sanity test has no way to validate that we are not attempting the invalid task of trying to create a block volume backed by a filesystem snapshot: https://gitlab.com/kubesan/kubesan/-/merge_requests/45#note_1960468190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant