Sanity: "pagination should detect volumes added between pages" removes volumes it didn't create & other issues

[davidz627]

This test specifically checks for "existing volumes" by doing a ListVolumes call then afterwards does removing all listed volumes

This means that this test could removes all volumes listed even if the volume was not created by this test. This could cause data loss depending on how a consumer is using CSI sanity.

This brings up a larger problem I have with this test too - either

1. You are consuming csi-sanity and mocking out the back-end (this is what I do) -> this test is way too complicated and depends on the workings of pagination and doesn't feel like a simple "sanity test" like the rest of the package
2. You are not mocking out the backend -> this test has potential for data loss

[davidz627]

/cc @msau42 @lpabon @pohly @darkowlzz

[msau42]

I agree that the test should only remove volumes created by the test.
/kind bug
/help

[k8s-ci-robot]

@msau42:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

I agree that the test should only remove volumes created by the test.
/kind bug
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timoreimann]

I'd be happy to take a stab at this one.

[timoreimann]

/assign @timoreimann

[pohly]

Note that the test is currently disabled (#226) because it was so problematic.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[msau42]

/lifecycle frozen