-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce CSI proxy CPU usage #197
Conversation
Hi @pradeep-hegde. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/kind bug |
/remove-kind feature |
1a4e966
to
74279e7
Compare
/assign @xing-yang |
/assign @jingxu97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One suggestion to change the parameters for the util.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ddebroy, pradeep-hegde The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Leaving lgtm to @mauriciopoppe / @jingxu97 |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This change will reduce CPU usage of csi proxy.
Util method to run PowerShell scripts is created. Powershell is invoked with a set of parameters to load and reduce CPU usage.
Which issue(s) this PR fixes:
Partially Fixes #193
Special notes for your reviewer:
CPU usage in the node before this change
CPU usage in one of the nodes with this change
Note:
Does this PR introduce a user-facing change?: