Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support addtional filter for extended resource pod #960

Open
fishingfly opened this issue Jul 29, 2024 · 2 comments
Open

Support addtional filter for extended resource pod #960

fishingfly opened this issue Jul 29, 2024 · 2 comments

Comments

@fishingfly
Copy link

fishingfly commented Jul 29, 2024

Hi

In our k8s cluster, we just want to evict gpu pods before node reboot, and there is no fixed label on these gpu pods, so kured cannot select these pods through the label selector by using the existing flag drain-pod-selector.

Can kured support addtional filter for extended resource pod?

@fishingfly fishingfly changed the title Support addtionnal filter for extended resource pod Support addtional filter for extended resource pod Jul 30, 2024
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@evrardjp
Copy link
Collaborator

Here is the code tackling the draining of the nodes:

kured/cmd/kured/main.go

Lines 515 to 526 in 969926d

drainer := &kubectldrain.Helper{
Client: client,
Ctx: context.Background(),
GracePeriodSeconds: drainGracePeriod,
PodSelector: drainPodSelector,
SkipWaitForDeleteTimeoutSeconds: skipWaitForDeleteTimeoutSeconds,
Force: true,
DeleteEmptyDirData: true,
IgnoreAllDaemonSets: true,
ErrOut: os.Stderr,
Out: os.Stdout,
Timeout: drainTimeout,
.

All pods matching those parameters will be evicted. I am not sure I understood the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants