slack: Allow legacy / proxy notification use-cases

[dholbach]

With #368 (at least TTBOMK) we stop supporting notification use-cases like

--slack-hook-url=http://eventmanager.notification.svc.cluster.local./api/notification/slack/2/kured

which is what we use in our cluster(s) - it's essentially kind of a proxy for various kind of notifications.

@atighineanu was thinking we add a --custom-slack-url option.

We should at the very least let people know in the release notes that we are changing the behaviour ... 🤷‍♂️

[dholbach]

Relevant log output:

2021-11-29T15:57:52.684347460Z time="2021-11-29T15:57:52Z" level=warning msg="Deprecated flag(s). Please use --notify-url flag instead."
2021-11-29T15:57:52.684404989Z time="2021-11-29T15:57:52Z" level=warning msg="slack-hook-url is not properly formatted...no notification will be sent: <nil>\n"

[dholbach]

I talked to our IT folks and they said they'd be happy to move away from the proxying use-case.

Question to the audience: does anyone of you use ^ this kind of custom Slack URL?

[dholbach]

Maybe we un-milestone the issue for now to reduce the importance somewhat? WDYT?

[evrardjp]

I do not have a proxy to some notification system, but I don't think I am the reference here ;)

I think however it would be right to warn that the slack-hook-url is not rightfully formatted, and still try it. If shoutrrr works with it, then good. If not, let's fix shoutr where/if necessary?

If we are to implement our own library/behaviour/"alternative ways", then it doesn't make much sense to use an existing library for notifications ;)

[dholbach]

✔️ There was a warning as you can see in the log output above.

It'll just be a bit hard to find out who might get surprised by this behaviour. In the case of our Dev environment, the Slack notifications just stopped happening. I'm willing to accept though that this is one of the few cases and everybody else just uses the Slack hook notation. 🤷

[github-actions]

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).