Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output artifact annotations to accept underscore and dash names #1280

Open
Tomcli opened this issue Jul 11, 2023 · 0 comments
Open

Fix output artifact annotations to accept underscore and dash names #1280

Tomcli opened this issue Jul 11, 2023 · 0 comments
Labels

Comments

@Tomcli
Copy link
Member

Tomcli commented Jul 11, 2023

/kind bug

the first name worked but the second name doesn't. We should make dash and underscore work for artifact name annotations as well.

What steps did you take and what happened:
receive_file_task = receive_file_op(
send_file_task.output,
).add_pod_annotation(name='artifact_outputs', value=json.dumps(['saveartifact']))

receive_file_task = receive_file_op(
send_file_task.output,
).add_pod_annotation(name='artifact_outputs', value=json.dumps(['save-artifact']))

What did you expect to happen:

Additional information:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Python Version (use python --version):
  • SDK Version:
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant