Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion on how to trim down Tekton/Argo go pkg to resolve go.mod conflicts. #1240

Open
Tomcli opened this issue May 16, 2023 · 2 comments

Comments

@Tomcli
Copy link
Member

Tomcli commented May 16, 2023

/kind feature

Description:
As part of contributing back KFP-Tekton V2 to upstream. One of the challenges is to resolve the go pkg conflicts between Argo and Tekton. In 2020, Argo and Tekton had many go-client conflicts in their pkg which is one of the reasons we have to separate the code base. Fast forward to today, Tekton still have the Knative dependency which conflicts with Argo's log and grpc-gateway packages. We want to see can we come up or rebuilt a new Tekton/Argo go pkg that can trim down from the original package because we only need the Tekton/Argo client to create the corresponding CRDs.

There are few options I have in mind:

  1. Write our own Tekton/Argo go pkg that doesn't include unnecessary packages. However, we need to constantly sync and update our client package with the upstream Tekton/Argo project.
  2. Contribute to both Tekton and Argo and create a small go client package similar to k8s.io/api. However, this requires us to get involve in multiple communities which we already see many challenges when contributing to the Tekton core API.

Any thoughts?

Additional information:
[Miscellaneous information that will assist in solving the issue.]

@Tomcli
Copy link
Member Author

Tomcli commented May 16, 2023

cc @yhwang @rimolive

@Tomcli Tomcli changed the title Discussion on how to trim down Tekton/Argo go pkg to resolve conflicts. Discussion on how to trim down Tekton/Argo go pkg to resolve go.mod conflicts. May 16, 2023
@Tomcli
Copy link
Member Author

Tomcli commented Jun 27, 2023

related: tektoncd/pipeline#6483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant