Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests to cover more scenario for the new kfp-tekton v1 api #1181

Open
Tomcli opened this issue Mar 10, 2023 · 4 comments
Open
Assignees

Comments

@Tomcli
Copy link
Member

Tomcli commented Mar 10, 2023

/kind feature

Description:
Right now we see some edge cases in the new v1 api changes were not able to cover with our e2e test. Therefore, we need to create a set of tests just to list and get runs and experiments from the Python sdk/cli.

Additional information:
[Miscellaneous information that will assist in solving the issue.]

@Tomcli
Copy link
Member Author

Tomcli commented Mar 10, 2023

related #1180 #1179

@Tomcli
Copy link
Member Author

Tomcli commented Mar 10, 2023

/assign @yhwang

@yhwang
Copy link
Member

yhwang commented Mar 10, 2023

In existing e2e test cases, the CLI is used to upload pipelines, create runs, and list runs. Seems those changes address bugs for experiment-related APIs. I believe adding some test cases to call experiment-related APIs should be good for now. Any suggestion?

@Tomcli
Copy link
Member Author

Tomcli commented Mar 10, 2023

yeah we need to have some tests on listing experiments and runs. In the case of listing runs we might want to cover few cases like listing run with different namespaces to cover each condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants