Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor toast messages #8

Open
bartacc opened this issue Jul 24, 2024 · 0 comments
Open

Refactor toast messages #8

bartacc opened this issue Jul 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@bartacc
Copy link
Collaborator

bartacc commented Jul 24, 2024

As I said, toast is created as a reaction to user action: the user clicks the button, it calls API, and we have a "success" response, so we display a "success" toast. For this kind of message, we should be able to use toast function inside methods that handles this interactions/API call. For backend notifications, like "your lecture was accepted," which can happen without user interaction or even without the user being on the website, we should show some notification bell on the navbar that will display those messages ("System Zapisów" is a good example). A quick look through Django Docs shows that this is both, right? So, there is no good solution here.

If we can separate those two types of messages, that would be perfect, but maybe we should create a task for it later and leave it as it currently is.

Originally posted by @Arsenicro in #7 (comment)

@bartacc bartacc added the enhancement New feature or request label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant