Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to use other kinds of user private keys than RSA #19

Open
krtab opened this issue Oct 13, 2022 · 6 comments
Open

Allow users to use other kinds of user private keys than RSA #19

krtab opened this issue Oct 13, 2022 · 6 comments
Labels
enhancement New feature or request upstream

Comments

@krtab
Copy link
Owner

krtab commented Oct 13, 2022

No description provided.

@krtab krtab added the enhancement New feature or request label Oct 13, 2022
@krtab krtab self-assigned this Oct 13, 2022
@krtab krtab changed the title Allow users ot use other kind of user private keys than RSA Allow users to use other kinds of user private keys than RSA Oct 13, 2022
@krtab
Copy link
Owner Author

krtab commented Jan 5, 2023

This limitation currently stems from acme2.
Cf: lucacasonato/acme2#22

@krtab krtab added the upstream label Jan 5, 2023
@Jay2k1
Copy link

Jay2k1 commented Feb 6, 2023

Not sure how common my use case is, but:

I desperately wanted to use a LE wildcard, but my DNS provider does not have an API. I was so glad I found this tool! However, when realizing I had to provide an RSA key and, being a prior certbot user, could only find a weird json key file (/etc/letsencrypt/accounts/acme-v02.api.letsencrypt.org/directory/<uid>/private_key.json), I was a bit puzzled.

After a bit of googling, I found a thread with several code samples or links, dealing with how to convert that key into RSA. There's Java and Go, and I also found a Python script which I ended up using.

So now that there are three different implementations, I wonder if this could be adapted and added to agnos so it would accept either an RSA key or the JSON format that probably many users are going to already have if they're switching from certbot with non-wildcard certificates.

(btw, thank you so much, this tool is ingenious and awesome!)

@krtab
Copy link
Owner Author

krtab commented Feb 10, 2023

HI!

Thanks a lot for your very kind words, feedback is immensely precious! I'm opening a new issue regarding your demand, as this one centers more on the cryptography algorithm than the file format. I'll try to have a look at it when I have time.

@justinas
Copy link
Contributor

justinas commented Mar 2, 2023

I have started messing around with adding P-256 support to acme2.

Sadly, it seems that JWK/JWS/JWT ecosystem is not perfectly mature in Rust, so acme2 implements these with its own bespoke code and OpenSSL's crypto primitives. So the process isn't as easy as it could be in e.g. Go where there's stuff like stdlib crypto and go-jose.

@justinas
Copy link
Contributor

justinas commented Mar 3, 2023

I've submitted a PR adding P-256 account key support to to acme2: lucacasonato/acme2#23

@krtab
Copy link
Owner Author

krtab commented Mar 3, 2023

Great news!

@krtab krtab removed their assignment Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream
Projects
None yet
Development

No branches or pull requests

3 participants