Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to the Graph API #259

Open
spmallette opened this issue Sep 28, 2023 · 2 comments
Open

Remove references to the Graph API #259

spmallette opened this issue Sep 28, 2023 · 2 comments

Comments

@spmallette
Copy link
Collaborator

At this point, we really don't talk about using Blueprints level Graph API for doing things. Folks operate at a Gremlin level. There's some references to the Graph API in the book that should probably be removed, like: "4.5.1. Adding an airport (vertex) and a route (edge)" which adds a detracting statement of:

While using the graph object in this way works, it is strongly recommended that the traversal source object g be used instead and that vertices and edges be added using a traversal.

Not sure if there are other references to it offhand, but I think it's worth a good going over to clean that up.

@krlawrence
Copy link
Owner

krlawrence commented Sep 28, 2023

There's also a fair bit of graph.io that now needs to be g.io both in the manuscript and some of the sample code. There are also several examples of graph.traversal() that could be reworked. The mentions in Section 2.3 where graph.features() is mentioned also needs some reworking.

Files to consider changing include

  1. https://github.com/krlawrence/graph/blob/main/sample-data/load-air-routes-graph-34.groovy
  2. https://github.com/krlawrence/graph/blob/main/sample-data/load-air-routes-graph.groovy
  3. graph.io(graphml()).readGraph('data/air-routes.graphml')
  4. graph.io(graphml()).readGraph('air-routes.graphml')
  5. graph.io(graphml()).readGraph('air-routes.graphml')
  6. graph.io(graphml()).readGraph('air-routes.graphml')
  7. graph.io(graphml()).readGraph('air-routes.graphml')
  8. graph.io(graphml()).readGraph('data/air-routes.graphml')

@krlawrence
Copy link
Owner

See also issue #201

krlawrence added a commit that referenced this issue Oct 9, 2023
krlawrence added a commit that referenced this issue Oct 9, 2023
spmallette added a commit that referenced this issue Dec 5, 2023
The anonymous traversal source with() syntax is in 4.x now and is a bit more streamlined than what was there before. There may yet be some spots that were missed, but most should be covered. This also covers a lot of Graph API removal. #265 #259
spmallette added a commit that referenced this issue Dec 11, 2023
The anonymous traversal source with() syntax is in 4.x now and is a bit more streamlined than what was there before. There may yet be some spots that were missed, but most should be covered. This also covers a lot of Graph API removal. #265 #259
@github-project-automation github-project-automation bot moved this to In Progress in Planning Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

2 participants