Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 Upgrade and the open method #8

Open
kellyeryan opened this issue Oct 26, 2023 · 3 comments
Open

Ruby 3 Upgrade and the open method #8

kellyeryan opened this issue Oct 26, 2023 · 3 comments
Assignees

Comments

@kellyeryan
Copy link
Contributor

kellyeryan commented Oct 26, 2023

Hi! My company is upgrading to Ruby 3 from version 2.7.

In 2.7 open checks whether there is a path or url and accommodates based on that check. Ruby 3 has removed that functionality so now it is necessary to do a manual check to prevent breakage. We have some code breaking in our application because of the lost functionality.

Here is where the issue appears in kramdown-converter-pdf. We believe we can fix the issue. We know the repo is unmaintained, but would you accept a patch to fix the problem? Alternatively powerhome could take ownership of the repo and then we could update it ourselves.

@gettalong gettalong self-assigned this Oct 26, 2023
@gettalong
Copy link
Member

If you provide a patch, I will apply it and release a new version.

@kellyeryan
Copy link
Contributor Author

kellyeryan commented Oct 27, 2023

Thanks so much! I'll get it done today.

@kellyeryan
Copy link
Contributor Author

I've tested this code within our application (I monkey patched it in and ran it locally) and it fixes the error we were getting. Is there anything else you'd like me to do to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants