Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically discard insignificant osm extracts and allow users downloading extracts by name #133

Conversation

RaczeQ
Copy link
Collaborator

@RaczeQ RaczeQ commented Jul 6, 2024

No description provided.

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 96.84211% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.22%. Comparing base (7855b18) to head (2b3de56).

Files Patch % Lines
quackosm/osm_extracts/__init__.py 93.00% 7 Missing ⚠️
quackosm/osm_extracts/extract.py 97.05% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   93.00%   93.22%   +0.22%     
==========================================
  Files          21       22       +1     
  Lines        1729     1935     +206     
==========================================
+ Hits         1608     1804     +196     
- Misses        121      131      +10     
Flag Coverage Δ
macos-13-python3.12 93.22% <96.84%> (+0.22%) ⬆️
ubuntu-latest-python3.10 93.22% <96.84%> (+0.22%) ⬆️
ubuntu-latest-python3.11 93.22% <96.84%> (+0.22%) ⬆️
ubuntu-latest-python3.12 93.22% <96.84%> (+0.22%) ⬆️
ubuntu-latest-python3.9 93.22% <96.83%> (+0.22%) ⬆️
windows-latest-python3.12 93.22% <96.84%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

quackosm/functions.py Outdated Show resolved Hide resolved
quackosm/functions.py Outdated Show resolved Hide resolved
@RaczeQ RaczeQ marked this pull request as ready for review August 12, 2024 14:47
@RaczeQ RaczeQ merged commit 251634b into main Aug 12, 2024
14 checks passed
@RaczeQ RaczeQ deleted the 115-add-option-to-discard-osm-extracts-if-intersection-area-is-insignificant branch August 12, 2024 15:33
@RaczeQ RaczeQ linked an issue Aug 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant