Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't download dcs roles that I don't want #66

Closed
mancdaz opened this issue Sep 30, 2019 · 6 comments · Fixed by #67
Closed

Don't download dcs roles that I don't want #66

mancdaz opened this issue Sep 30, 2019 · 6 comments · Fixed by #67

Comments

@mancdaz
Copy link

mancdaz commented Sep 30, 2019

How do I ignore the roles that I don't want from the role meta/main.yml? I am not going to use zookeeper (and that role is broken due to version number scheme change), nor etcd. I want to use only consul, but all three roles get downloaded when I install this role with ansible-galaxy

@kostiantyn-nemchenko
Copy link
Owner

@mancdaz Yes, all 3 roles will be downloaded but only one of them will be ultimately applied to your infrastructure depending on the value of patroni_dcs variable. Currently, AFAIK there is no way in Ansible to achieve what you want. Please, also see this issue to get more details. Would appreciate any ideas or workarounds if you have ones.

@mancdaz
Copy link
Author

mancdaz commented Sep 30, 2019

@kostiantyn-nemchenko ok thanks.

In that case can I suggest you at least specify a version in your dependency, because at the moment the zookeeper role download will fail due to this issue. Basically, they removed the 'v' from the latest version 0.23.0 and don't appear to be responsive to suggestions of fixing it.

@mancdaz
Copy link
Author

mancdaz commented Sep 30, 2019

Personally, I would document the need for a dcs, but not enforce any roles as dependencies. There are many use cases where a user will already have a dcs, and has no need for any of those roles (or indeed wants to use a different role to manage their dcs). I'd rather see less forced upon the user, and give them the option to use composability in their playbooks instead. Just my 2p.

@kostiantyn-nemchenko
Copy link
Owner

@mancdaz Thanks for the valuable suggestions. I'll try to update the docs and the dependency file as soon as possible, because you are not the first one to face this problem.

@kostiantyn-nemchenko
Copy link
Owner

@mancdaz Suggested changes are in the master. Hope you will find this role useful. Thanks for the input.

@mancdaz
Copy link
Author

mancdaz commented Sep 30, 2019

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants