Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing comment strings from hsd #6

Closed
bhourahine opened this issue Nov 29, 2023 · 2 comments
Closed

Removing comment strings from hsd #6

bhourahine opened this issue Nov 29, 2023 · 2 comments

Comments

@bhourahine
Copy link

There is a problem reading the dftb_in.hsd template in restart_filemaker.py when there are comments in certain hsd blocks. For example:

Geometry = GenFormat {
<<< my_file # this is a comment
}

As the script will then try to read the file "my_file # this is a comment" instead of "my_file". It's not clear to me whether this is best solved in the hsd library or the script.

@korintje
Copy link
Owner

Thank you for your report.

I have confirmed that placing the comment in a specific location in dftb_in.hsd causes the issue you pointed out.
Just calling hsd.load(HSD_FILENAME) like the following short script causes the error.

import hsd
hsdinput = hsd.load("dftb_in.hsd")

Therefore, I suppose there is nothing I can do on the script side so far.
I think we need to fix the hsd library.

@bhourahine
Copy link
Author

I've raised an issue on the library side at:
dftbplus/hsd-python#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants