Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support for env parsing. #17

Open
wants to merge 2 commits into
base: move_to_bazel
Choose a base branch
from
Open

WIP: Add support for env parsing. #17

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 21, 2016

Expand env vars after yaml expansion

Quick example supporting issue #15
Merged against the move_to_bazel branch instead since it seems like that's where you are going with tests, etc.

Context

When dealing with a ci pipeline it is desirable to be able to merge both
static and dynamic configurations.

This includes scenarios where you want to load an application manifest and merge characteristics like build versions from pipeline environment vars.

Solution

Add support to kexpand to an environment expansion in addition to the yaml expansion.
Leveraging an API like https://github.com/a8m/envsubst (or something that accomplishes the same functionality) to provide this behavior with limited modification.

image

Remaining work

  • Test cases
  • Confirm if github.com/a8m/envsubst is the api you want to use
  • Passthrough unknown vars as literals

@ghost ghost mentioned this pull request Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants