Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in "kubefirst beta google destroy" #2205

Closed
1 task done
mrsimonemms opened this issue Jun 19, 2024 · 2 comments
Closed
1 task done

Broken link in "kubefirst beta google destroy" #2205

mrsimonemms opened this issue Jun 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Jun 19, 2024

Which version of kubefirst are you using?

2.4.10

Which cloud provider?

Google Cloud

Which DNS?

None specific

Which installation type?

CLI

Which distributed Git provider?

None specific

Did you use a fork of gitops-template?

No

Which Operating System?

Linux

What is the issue?

When running the kubefirst beta google destroy command, it displays the link "https://docs.kubefirst.io/google/deprovision". This returns a default nginx 404 (see also konstructio/kubefirst-docs#721).

The correct link should be https://docs.kubefirst.io/gcp/overview.

image

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mrsimonemms mrsimonemms added the bug Something isn't working label Jun 19, 2024
@jairoFernandez
Copy link
Member

jairoFernandez commented Jun 19, 2024

apparently we are using this funtion to resolve the Deprovision message:

https://github.com/kubefirst/kubefirst/blob/55e58cf642db4e48b11bdede6ba0f0a0d6077b4e/internal/common/common.go#L183,

We need to discuss with Fred if is more easy to change the documentation from https://docs.kubefirst.io/gcp/** to https://docs.kubefirst.io/google/**

For example the deprovision page exists https://docs.kubefirst.io/gcp/deprovision

@jairoFernandez
Copy link
Member

I'll close this issue, we solve temporally doing a redirect from /google/** to /gcp/**, in this PR konstructio/kubefirst-docs#715, thanks a lot @mrsimonemms for your catch!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants