Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Case for combined address #696

Open
xeruf opened this issue Oct 8, 2022 · 1 comment
Open

Edge Case for combined address #696

xeruf opened this issue Oct 8, 2022 · 1 comment

Comments

@xeruf
Copy link

xeruf commented Oct 8, 2022

I encountered an example where I tried to geocode Fichtestraße 1-4, 08451 Crimmitschau Chemnitz.

It fails, even though two query variations which would combine into it work out:

curl 'https://photon.komoot.io/api/?q=Fichtestraße%201-4,%2008451%20Crimmitschau%20Chemnitz&lang=de&limit=1'
{"features":[],"type":"FeatureCollection"}

curl 'https://photon.komoot.io/api/?q=Fichtestraße%201-4,%2008451%20Crimmitschau&lang=de&limit=1'
{"features":[{"geometry":{"coordinates":[12.393781675026666,50.80871965],"type":"Point"},"type":"Feature","properties":{"osm_id":570446453,"extent":[12.3937017,50.8088135,12.3938617,50.8086258],"country":"Deutschland","city":"Crimmitschau","countrycode":"DE","postcode":"08451","locality":"Wahlen","county":"Zwickau","type":"house","osm_type":"W","osm_key":"building","housenumber":"1","street":"Fichtestraße","district":"Crimmitschau","osm_value":"yes","state":"Sachsen"}}],"type":"FeatureCollection"}

curl 'https://photon.komoot.io/api/?q=Fichtestraße%201,%2008451%20Crimmitschau%20Chemnitz&lang=de&limit=1'
{"features":[{"geometry":{"coordinates":[12.393781675026666,50.80871965],"type":"Point"},"type":"Feature","properties":{"osm_id":570446453,"extent":[12.3937017,50.8088135,12.3938617,50.8086258],"country":"Deutschland","city":"Crimmitschau","countrycode":"DE","postcode":"08451","locality":"Wahlen","county":"Zwickau","type":"house","osm_type":"W","osm_key":"building","housenumber":"1","street":"Fichtestraße","district":"Crimmitschau","osm_value":"yes","state":"Sachsen"}}],"type":"FeatureCollection"}

Is it possible to fix cases like this?

@lonvia
Copy link
Collaborator

lonvia commented Oct 22, 2022

There are two errors in that address. There is no housenumber '1-4' and the address is not in Chemnitz. That's a bit too much even for fuzzy search. It is extremely difficult to accommodate for cases like this without making other searches return worse results. So the answer would be: no, sorry, it's unlikely to be fixable. You have to clean your input on the client side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants