Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: add domain configuration #3

Open
lakuapik opened this issue Jun 19, 2023 · 3 comments
Open

Enhance: add domain configuration #3

lakuapik opened this issue Jun 19, 2023 · 3 comments

Comments

@lakuapik
Copy link
Member

lakuapik commented Jun 19, 2023

Currently we do not support domain in api config, would be nice to have.

@lakuapik
Copy link
Member Author

@axmad386 would you mind help us do this? haha

@axmad386
Copy link
Member

@lakuapik I don't get it. How custom domains are needed in this package. It's kodepandai/laravel-indonesia. Did you mean to add this issue to kodepandai/laravel-api-response?

@lakuapik
Copy link
Member Author

currently we have an open api, can be configured here https://github.com/kodepandai/laravel-indonesia/blob/master/config/indonesia.php, it would be nice if we have on option to set domain name since we can configure the path and prefix.

https://laravel.test => main website
https://api.laravel.test/api/indonesia => api endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants