Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Front-end development article #9

Open
magicznyleszek opened this issue Nov 22, 2022 · 0 comments
Open

Update Front-end development article #9

magicznyleszek opened this issue Nov 22, 2022 · 0 comments

Comments

@magicznyleszek
Copy link
Member

Some things that definitely need to be changed:

  • Code style section:
    • Update point about JSDoc: it should say we try to use JSDoc-like comments for TypeScript, as it's being used by IDEs
    • Fix all the links for prettier, stylelint, and eslint (and fix others to point to main branch). Most possibly some of these should point to kobo-common project
    • Remove point about BEM, write one about CSS Modules. Add note about dropping bem?
    • Add whole subsection about configuring and using linters in vim, Sublime Text, VS Code, and terminal
  • Files architecture section:
    • Add point about functional components preference
    • Add point about filename suffixes (.module, .component, .utils)?
    • remove "don’t use relative paths in imports"
  • Icons section:
  • Typescript migration section:
    • rewrite point about dataInterface.d.ts, we store store types in dataInterface.ts
    • drop Reflux point

Add stuff from David's presentation: https://docs.google.com/presentation/d/1o2BaJlmaAtjcmsHiKRha5lyIMeMP2y6i2pgg7BKO8k0/edit#slide=id.g192d826b716_0_82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant