Let's Encrypt / Nginx scripts expect obsolete "docker-compose" command

[ekansa]

Description
Like many people on the forum, I ran into problems with Let's Encrypt + Nginx configurations. I think part of the problem may center on changes to Docker compose. The command to invoke docker compose went from docker-compose to docker compose

For example:

myname@kobo:~/kobo-install$ which docker-compose
myname@kobo:~/kobo-install$ which docker compose
/usr/bin/docker

The docker DASH compose (docker-compose) seems expected here: https://github.com/kobotoolbox/kobo-install/blob/master/templates/nginx-certbot/init-letsencrypt.sh.tpl#LL12C38-L12C38

Because which docker-compose returns a null result, the init-letsencrypt.sh fails to actually execute any docker compose related command.

As a workaround, I added a script to my server that mimics the old docker-compose command (see: https://stackoverflow.com/questions/72099653/how-to-alias-docker-compose-to-docker-compose/72187587#72187587), and that seems to have resolved the problems with HTTPS / Let's Encrypt in the setup!

I suggest modifying the init-letsencrypt.sh.tpl so that it can check not just for the old form of the docker-compose command, but also the new form of the command, docker compose (without the dash)

• OS: Ubuntu 22.04 LTS
• Docker Compose Version: Docker Compose version v2.18.1

Additional context
I was trying to diagnose why I got these errors:

init-letsencrypt.sh: line 34: run: command not found
init-letsencrypt.sh: line 43: up: command not found
init-letsencrypt.sh: line 47: run: command not found
init-letsencrypt.sh: line 70: run: command not found
init-letsencrypt.sh: line 81: exec: nginx_ssl_proxy: not found