Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.022.08 breaks Certificate Check #186

Closed
amks1 opened this issue Apr 3, 2022 · 1 comment · Fixed by #233
Closed

v2.022.08 breaks Certificate Check #186

amks1 opened this issue Apr 3, 2022 · 1 comment · Fixed by #233
Assignees
Labels
bug Something isn't working

Comments

@amks1
Copy link

amks1 commented Apr 3, 2022

Description

In the new version (I tested with tag 2.022.08) where the question to fetch the certificates from LetsEncrypt appears after the containers are built instead of before I noticed the following issues:

  1. If I choose "N" (don't re-fetch certificates) for a previously installed domain, all containers come up but the website is unreachable. I have to always fetch certificates in order to continue. Because I was doing tests I kept hitting the LetsEncrypt limits and had to keep making new subdomains. Which brings me to the next point.
  2. It always says that the certificates are present even if I enter a brand new subdomain name.

Steps to Reproduce: Issue 1 above

  1. Run run.py --setup and install new certificates.
  2. Run run.py --setup again, presumably with some changes. But don't install new certificates when asked.
  3. Containers come up but website is unreachable.
  4. Run run.py --setup again, with no other changes other than this time, choose "y" for the certificate.
  5. Containers come up and website is working.

Steps to Reproduce: Issue 2 above

  1. Run run.py --setup and install new certificates.
  2. Run run.py --setup again, with a different subdomain.
  3. At the time of certificate check, it says that the certificates are already present for this domain.
@noliveleger
Copy link
Contributor

@amks1,
Issue 1 was indeed a problem with --setup not bringing up the letsencrypt containers.
For the latter, #233 should fix it but if all subdomains are changed. If you changed only one or two but not first one, the prompt will still appear.
It's because of the way certbot generates folders. it only uses the first domain as the folder name.
Because it is an edge case, it is easier to delete the folder entirely and let the init script recreate it entirely

@noliveleger noliveleger added the bug Something isn't working label Sep 13, 2023
@noliveleger noliveleger self-assigned this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants